ocket8888 commented on a change in pull request #3930: Rewrite profile import
to Go
URL: https://github.com/apache/trafficcontrol/pull/3930#discussion_r331142857
##########
File path: traffic_ops/traffic_ops_golang/dbhelpers/db_helpers.go
##########
@@ -346,3 +346,15 @@ func GetCacheGroupNameFromID(tx *sql.Tx, id int64)
(tc.CacheGroupName, bool, err
}
return tc.CacheGroupName(name), true, nil
}
+
+// GetCacheGroupNameFromID Get Cache Group name from a given ID
+func GetParameterID(tx *sql.Tx, id int64) (tc.CacheGroupName, bool, error) {
Review comment:
Looks like a mismatch of the function name between the GoDoc and the actual
definition. I'd suggest you go with `GetCacheGroupNameFromID`, because that's
what it's doing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
