ajschmidt commented on a change in pull request #3961: added ability to select
TLS version in TR
URL: https://github.com/apache/trafficcontrol/pull/3961#discussion_r332646525
##########
File path:
traffic_router/connector/src/main/java/com/comcast/cdn/traffic_control/traffic_router/protocol/RouterNioEndpoint.java
##########
@@ -120,5 +121,13 @@ protected void doRun(){
}
}
+ public String getProtocols() {
+ return protocols;
+ }
+
+ public void setProtocols(final String protocols) {
+ this.protocols = protocols;
+ }
+
Review comment:
I think this should be using the 'sslProtocol' attribute that is already
part of the specification. Was there a problem with that? I don't think its
good to invent custom attributes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
