rob05c commented on a change in pull request #3964: Add GET/POST/DELETE for
server_server_capabilities
URL: https://github.com/apache/trafficcontrol/pull/3964#discussion_r333614793
##########
File path: traffic_ops/app/db/seeds.sql
##########
@@ -659,6 +666,10 @@ insert into api_capability (http_method, route,
capability) values ('PUT', 'serv
insert into api_capability (http_method, route, capability) values ('POST',
'servers/*/update_status', 'servers-write') ON CONFLICT (http_method, route,
capability) DO NOTHING;
insert into api_capability (http_method, route, capability) values ('GET',
'servers/checks', 'servers-read') ON CONFLICT (http_method, route, capability)
DO NOTHING;
insert into api_capability (http_method, route, capability) values ('POST',
'servercheck', 'servers-write') ON CONFLICT (http_method, route, capability) DO
NOTHING;
+-- server capabilities
+insert into api_capability (http_method, route, capability) values ('GET',
'server_server_capabilities', 'server-server-capabilities-read') ON CONFLICT
(http_method, route, capability) DO NOTHING;
Review comment:
I'd agree, I can't see a TC Admin wanting to ever let a person change only
server caps, but nothing else on the server. Likewise, I can't imagine a DS
Tenant ever wanting to let one of their employees change DS caps, but nothing
else on the ds.
I think lack of granularity is fine here. That said, I don't have a strong
opinion either way.
+0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
