lbathina edited a comment on issue #3966: Add server capabilities API URL: https://github.com/apache/trafficcontrol/pull/3966#issuecomment-540884030 1. ```{ "alerts": [ { "text": "no server capability with that id found", "level": "error" } ] }``` message here needs to be corrected. we are deleting server_capabilities only by name. 2. when spaces are at the start and end of name, they are trimmed and accepted instead of throwing error. 3. api parameters are not validated. for instance, requesting service_capabilities endpoint with param id doesn't throw any error. 4. on PUT which is not defined - may be we should do method not allowed? 5. When a post with no body is made. the following error is provided. ```{ "alerts": [ { "text": "EOF", "level": "error" } ] }``` instead of a meaningful message indicating the missing info.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
