mhoppa commented on a change in pull request #3967: Rewrite DELETE federation
delivery service to golang
URL: https://github.com/apache/trafficcontrol/pull/3967#discussion_r334139892
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -445,7 +445,7 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
{1.1, http.MethodGet, `federations/?(\.json)?$`,
federations.Get, auth.PrivLevelFederation, Authenticated, nil},
{1.1, http.MethodPost,
`federations/{id}/deliveryservices?(\.json)?$`, federations.PostDSes,
auth.PrivLevelAdmin, Authenticated, nil},
{1.1, http.MethodGet,
`federations/{id}/deliveryservices?(\.json)?$`,
api.ReadHandler(&federations.TOFedDSes{}), auth.PrivLevelReadOnly,
Authenticated, nil},
- {1.1, http.MethodDelete,
`federations/{id}/deliveryservices?(\.json)?$`,
api.DeleteHandler(&federations.TOFedDSes{}), auth.PrivLevelAdmin,
Authenticated, nil},
+ {1.1, http.MethodDelete,
`federations/{id}/deliveryservices/{dsID}/?(\.json)?$`,
api.DeleteHandler(&federations.TOFedDSes{}), auth.PrivLevelAdmin,
Authenticated, nil},
Review comment:
yeah it does from my initial commit but not master. my initial commit I was
replacing the perl path of _federations/{id}/deliveryservices/{dsID}_ with
_/federations/(ID}/deliveryservices_ but that was going to break the API so i
backed it out and went back to the correct path
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
