ocket8888 commented on a change in pull request #3534: TP Delivery Service
Generate SSL update, new letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r334639314
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryServiceSslKeys/generate/FormGenerateDeliveryServiceSslKeysController.js
##########
@@ -295,29 +296,54 @@ var FormGenerateDeliveryServiceSslKeysController =
function(deliveryService, ssl
];
$scope.confirmGenerate = function(sslRequest) {
- var params = {
- title: 'Generate New SSL Keys for Delivery Service: ' +
deliveryService.xmlId ,
- message: ' (replacing any previous keys)'
- };
- var modalInstance = $uibModal.open({
- templateUrl:
'common/modules/dialog/confirm/dialog.confirm.tpl.html',
- controller: 'DialogConfirmController',
- size: 'md',
- resolve: {
- params: function () {
- return params;
- }
- }
- });
- modalInstance.result.then(function() {
- deliveryServiceSslKeysService.generateSslKeys(deliveryService,
sslKeys, sslRequest).then(
- function() {
- locationUtils.navigateToPath('/delivery-services/' +
deliveryService.id + '/ssl-keys');
- });
- }, function () {
- // do nothing
- });
- };
+ var params = {
+ title: 'Generate New SSL Keys for Delivery Service: ' +
deliveryService.xmlId,
+ message: ' (replacing any previous keys)'
+ };
+ var modalInstance = $uibModal.open({
+ templateUrl:
'common/modules/dialog/confirm/dialog.confirm.tpl.html',
+ controller: 'DialogConfirmController',
+ size: 'md',
+ resolve: {
+ params: function () {
+ return params;
+ }
+ }
+ });
+ modalInstance.result.then(function() {
+ deliveryServiceSslKeysService.generateSslKeys(deliveryService,
sslKeys, sslRequest).then(
+ function() {
+ locationUtils.navigateToPath('/delivery-services/' +
deliveryService.id + '/ssl-keys');
+ });
+ }, function () {
+ // do nothing
+ });
+ };
+
+ $scope.confirmGenerateLetsEncrypt = function(sslRequest) {
+ var params = {
+ title: 'Generate New SSL Keys Using Let\'s Encrypt for Delivery
Service: ' + deliveryService.xmlId,
+ message: ' (replacing any previous keys)'
+ };
+ var modalInstance = $uibModal.open({
+ templateUrl:
'common/modules/dialog/confirm/dialog.confirm.tpl.html',
+ controller: 'DialogConfirmController',
+ size: 'md',
+ resolve: {
+ params: function () {
+ return params;
+ }
+ }
+ });
+ modalInstance.result.then(function() {
+
deliveryServiceSslKeysService.generateSslKeysWithLetsEncrypt(deliveryService,
sslKeys, sslRequest).then(
+ function() {
+ locationUtils.navigateToPath('/delivery-services/' +
deliveryService.id + '/ssl-keys');
+ });
+ }, function () {
+ // do nothing
Review comment:
Same as above RE doing nothing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
