ocket8888 commented on a change in pull request #3534: TP Delivery Service
Generate SSL update, new letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r334637642
##########
File path:
traffic_portal/app/src/common/modules/form/deliveryServiceSslKeys/form.deliveryServiceSslKeys.tpl.html
##########
@@ -54,6 +54,20 @@
<span ng-show="hasError(dsSslKeyForm.hostname)"
class="form-control-feedback"><i class="fa fa-times"></i></span>
</div>
</div>
+ <div class="form-group">
+ <label class="control-label col-md-2 col-sm-2
col-xs-12">Expiration</label>
+ <div class="col-md-10 col-sm-10 col-xs-12">
+ <input name="version" type="text"
class="form-control" ng-model="formattedExpiration" readonly>
Review comment:
instead of making this a read-only `input` with a JS-side filter, what if
you passed the output of the expiration to the filter directly in the DOM like:
`<output name="version">{{ formattedExpiration | date 'MM/dd/yyyy' }}</output>`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
