rawlinp commented on a change in pull request #3939: fixed bug in
CertificateRegistry
URL: https://github.com/apache/trafficcontrol/pull/3939#discussion_r335142220
##########
File path:
traffic_router/connector/src/main/java/com/comcast/cdn/traffic_control/traffic_router/protocol/RouterNioEndpoint.java
##########
@@ -53,10 +56,10 @@ protected void initialiseSsl() throws Exception {
}
}
- @SuppressWarnings({"PMD.NPathComplexity",
"PMD.UseStringBufferForStringAppends"})
- synchronized public void replaceSSLHosts(final Map<String,
HandshakeData> sslHostsData) {
- final Set<String> aliases = sslHostsData.keySet();
- String lastHostName = "";
+ synchronized private List<String> replaceSSLHosts(final Map<String,
HandshakeData> sslHostsData) {
Review comment:
Do you mind reformatting the additions here? This file appears to be mostly
tab-indented rather than space-indented.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
