mhoppa commented on a change in pull request #3989: Rewrote
/deliveryservices/request to Go
URL: https://github.com/apache/trafficcontrol/pull/3989#discussion_r335195831
##########
File path: lib/go-tc/enum.go
##########
@@ -220,6 +220,75 @@ func CacheStatusFromString(s string) CacheStatus {
}
}
+// Protocol represents an ATC-supported content delivery protocol.
+type Protocol string
Review comment:
incredibly nit but reason why we need to define a new type? We dont use it
outside this package and only for 5 strings
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
