ocket8888 commented on a change in pull request #3534: TP Delivery Service
Generate SSL update, new letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r335701097
##########
File path: lib/go-tc/deliveryservice_ssl_keys.go
##########
@@ -49,9 +55,11 @@ type DeliveryServiceSSLKeys struct {
Key string `json:"key"`
Version util.JSONIntStr `json:"version"`
Certificate DeliveryServiceSSLKeysCertificate
`json:"certificate,omitempty"`
+ Expiration time.Time
`json:"expiration,omitempty"`
Review comment:
You might have more pressing concerns. You can't add a field to the 1.3 API,
it's already been published. These fields have to be present _only_ in the 1.4
API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
