mattjackson220 commented on a change in pull request #3534: TP Delivery Service Generate SSL update, new letsencrypt generate and… URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r336053371
########## File path: traffic_ops/traffic_ops_golang/deliveryservice/letsencryptcert.go ########## @@ -0,0 +1,314 @@ +package deliveryservice + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import ( + "bytes" + "context" + "crypto" + "crypto/rand" + "crypto/rsa" + "crypto/x509" + "encoding/pem" + "errors" + "fmt" + "github.com/apache/trafficcontrol/lib/go-log" + "github.com/apache/trafficcontrol/lib/go-tc" + "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api" + "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/auth" + "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/config" + "github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/riaksvc" + "github.com/go-acme/lego/certcrypto" + "github.com/go-acme/lego/certificate" + "github.com/go-acme/lego/challenge" + "github.com/go-acme/lego/challenge/dns01" + "github.com/go-acme/lego/lego" + "github.com/go-acme/lego/registration" + "github.com/jmoiron/sqlx" + "net/http" + "strconv" + "strings" + "time" +) + +type MyUser struct { + Email string + Registration *registration.Resource + key crypto.PrivateKey +} + +func GetLetsEncryptTimeout() time.Duration { + return time.Minute * 10 +} + +func (u *MyUser) GetEmail() string { + return u.Email +} + +func (u MyUser) GetRegistration() *registration.Resource { + return u.Registration +} + +func (u *MyUser) GetPrivateKey() crypto.PrivateKey { + return u.key +} + +type DNSProviderTrafficRouter struct { + db *sqlx.DB +} + +func NewDNSProviderTrafficRouter() (*DNSProviderTrafficRouter, error) { + return &DNSProviderTrafficRouter{}, nil +} + +func (d *DNSProviderTrafficRouter) Timeout() (timeout, interval time.Duration) { + return GetLetsEncryptTimeout(), time.Second * 30 +} + +func (d *DNSProviderTrafficRouter) Present(domain, token, keyAuth string) error { + tx, err := d.db.Begin() + fqdn, value := dns01.GetRecord(domain, keyAuth) + + q := `INSERT INTO dnschallenges (fqdn, record) VALUES ($1, $2)` + response, err := tx.Exec(q, fqdn, value) + tx.Commit() + if err != nil { + log.Errorf("Inserting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + return errors.New("Inserting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + } else { + rows, err := response.RowsAffected() + if err != nil { + log.Errorf("Determining rows affected dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + return errors.New("Determining rows affected dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + } + if rows == 0 { + log.Errorf("Zero rows affected when inserting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + return errors.New("Zero rows affected when inserting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + } + } + + return nil +} + +func (d *DNSProviderTrafficRouter) CleanUp(domain, token, keyAuth string) error { + fqdn, value := dns01.GetRecord(domain, keyAuth) + tx, err := d.db.Begin() + + q := `DELETE FROM dnschallenges WHERE fqdn = $1 and record = $2` + response, err := tx.Exec(q, fqdn, value) + tx.Commit() + if err != nil { + log.Errorf("Deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + return errors.New("Deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + } else { + rows, err := response.RowsAffected() + if err != nil { + log.Errorf("Determining rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + return errors.New("Determining rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + } + if rows == 0 { + log.Errorf("Zero rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + return errors.New("Zero rows affected when deleting dns txt record for fqdn '" + fqdn + "' record '" + value + "': " + err.Error()) + } + } + + return nil +} + +func GenerateLetsEncryptCertificates(w http.ResponseWriter, r *http.Request) { + inf, userErr, sysErr, errCode := api.NewInfo(r, nil, nil) + if userErr != nil || sysErr != nil { + api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr) + return + } + defer inf.Close() + + ctx, _ := context.WithTimeout(r.Context(), GetLetsEncryptTimeout()) + + req := tc.DeliveryServiceLetsEncryptSSLKeysReq{} + if err := api.Parse(r.Body, nil, &req); err != nil { + log.Errorf("Error parsing request: %s", err.Error()) + api.HandleErr(w, r, nil, http.StatusBadRequest, errors.New("parsing request: "+err.Error()), nil) + return + } + + go GetLetsEncryptCertificates(inf.Config, req, ctx, inf.User) + + api.WriteRespAlert(w, r, tc.WarnLevel, "Beginning async call to Let's Encrypt for "+*req.DeliveryService+". This may take a few minutes.") + +} + +func GetLetsEncryptCertificates(cfg *config.Config, req tc.DeliveryServiceLetsEncryptSSLKeysReq, ctx context.Context, currentUser *auth.CurrentUser) error { + + db, err := api.GetDB(ctx) + if err != nil { + log.Errorf(*req.DeliveryService+": Error getting db: %s", err.Error()) + return err + } + tx, err := db.Begin() + if err != nil { + log.Errorf(*req.DeliveryService+": Error getting tx: %s", err.Error()) + return err + } + + logTx, err := db.Begin() + if err != nil { + log.Errorf(*req.DeliveryService+": Error getting logTx: %s", err.Error()) + return err + } + defer logTx.Commit() + + domainName := *req.HostName + deliveryService := *req.DeliveryService + + dsID, ok, err := getDSIDFromName(tx, *req.DeliveryService) + if err != nil { + log.Errorf("deliveryservice.GenerateSSLKeys: getting DS ID from name " + err.Error() + " " + ctx.Err().Error()) + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt", currentUser, logTx) + return errors.New("deliveryservice.GenerateSSLKeys: getting DS ID from name " + err.Error()) + } else if !ok { + log.Errorf("no DS with name " + *req.DeliveryService) + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt", currentUser, logTx) + return errors.New("no DS with name " + *req.DeliveryService) + } + tx.Commit() + + privateKey, err := rsa.GenerateKey(rand.Reader, 2048) + if err != nil { + log.Errorf(deliveryService+": Error generating private key: %s", err.Error()) + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt", currentUser, logTx) + return err + } + + myUser := MyUser{ + key: privateKey, + Email: cfg.ConfigLetsEncrypt.Email, + } + + config := lego.NewConfig(&myUser) + if strings.EqualFold(cfg.ConfigLetsEncrypt.Environment, "staging") { + config.CADirURL = lego.LEDirectoryStaging // provides certificate signed by invalid authority for testing purposes + } else { + config.CADirURL = lego.LEDirectoryProduction // provides certificate signed by valid LE authority + } + + config.Certificate.KeyType = certcrypto.RSA2048 + + client, err := lego.NewClient(config) + if err != nil { + log.Errorf(deliveryService+": Error creating lets encrypt client: %s", err.Error()) + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt", currentUser, logTx) + return err + } + + client.Challenge.Remove(challenge.HTTP01) + client.Challenge.Remove(challenge.TLSALPN01) + trafficRouterDns, err := NewDNSProviderTrafficRouter() + trafficRouterDns.db = db + if err != nil { + log.Errorf(deliveryService+": Error creating Traffic Router DNS provider: %s", err.Error()) + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt", currentUser, logTx) + return err + } + client.Challenge.SetDNS01Provider(trafficRouterDns) + + reg, err := client.Registration.Register(registration.RegisterOptions{TermsOfServiceAgreed: true}) + if err != nil { + log.Errorf(deliveryService+": Error registering lets encrypt client: %s", err.Error()) + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt", currentUser, logTx) + return err + } + myUser.Registration = reg + + priv, err := rsa.GenerateKey(rand.Reader, 2048) + if err != nil { + log.Errorf(deliveryService + ": Error generating private key") + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt", currentUser, logTx) + return err + } + request := certificate.ObtainRequest{ + Domains: []string{domainName}, + Bundle: true, + PrivateKey: priv, + } + + certificates, err := client.Certificate.Obtain(request) + if err != nil { + log.Errorf(deliveryService+": Error obtaining lets encrypt certificate: %s", err.Error()) + api.CreateChangeLogRawTx(api.ApiChange, "DS: "+*req.DeliveryService+", ID: "+strconv.Itoa(dsID)+", ACTION: FAILED to add SSL keys with Lets Encrypt "+err.Error(), currentUser, logTx) + return err + } + + fmt.Printf("%#v\n", certificates) Review comment: done. i just removed this line. on second thought we dont want to log this ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
