ezelkow1 opened a new issue #4005: ORT can possibly uninstall ATS without installing a new version URL: https://github.com/apache/trafficcontrol/issues/4005 <!-- ************ STOP!! ************ If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact the Apache Software Foundation Security Team at [email protected] and follow the guidelines at https://www.apache.org/security/ regarding vulnerability disclosure. --> <!-- - For *SUPPORT QUESTIONS*, use the [Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/). - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. --> ## I'm submitting a ... <!-- (check all that apply with "[x]") --> <!--- security vulnerability (STOP!! - see above)--> - [ ] bug report - [ ] new feature / enhancement request - [ ] improvement request (usability, performance, tech debt, etc.) - [ ] other <!--(Please do not submit support requests here - see above)--> ## Traffic Control components affected ... <!-- (check all that apply with "[x]") --> - [ ] CDN in a Box - [ ] Documentation - [ ] Grove - [ ] Traffic Control Client - [ ] Traffic Monitor - [ ] Traffic Ops - [ ] Traffic Ops ORT - [ ] Traffic Portal - [ ] Traffic Router - [ ] Traffic Stats - [ ] Traffic Vault - [ ] unknown ## Current behavior: <!-- Describe how the bug manifests / how the current features are insufficient. --> Using a testing environment we saw an issue where it was possible to have ORT uninstall the existing ATS install, and then not install a new version on top I.e. the parameter for the ATS package was ATS.7, however the actual package was ATS.7.x86_64. Im not sure how ORT determines what is installed vs what it is going to install, but in this instance it at least recognized that it was a trafficserver package, and so it uninstalled trafficserver. However at the end of that it then believed that all relevant packages were already installed: DEBUG result for /ort/TEST/packages is: ...[{"version":"ATS.7","name":"trafficserver"},{"version":"ATS.7","name":"trafficserver-debuginfo"}]... INFO Successfully uninstalled the following packages: - ATS.7.x86_64 - ATS-debuginfo.7.x86_64 INFO All of the required packages are installed. (package and machine names have been changed) So here it saw the new package name, uninstalled the existing one, but then did not install a new one leaving no installation in its place ## Expected / new behavior: <!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control --> I believe ort should check first that it can actually install the exact requested package before uninstalling the existing one. It may already be doing this but then the logic needs to be checked that it does not believe the packages are still installed, since something there is incorrect ## Minimal reproduction of the problem with instructions: <!-- If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the *STEPS TO REPRODUCE* and include the applicable TC version. --> Included in description ## Anything else: <!-- e.g. stacktraces, related issues, suggestions how to fix --> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
