mhoppa commented on a change in pull request #4026: Feature/add deliveryservice required capability URL: https://github.com/apache/trafficcontrol/pull/4026#discussion_r339106206
########## File path: traffic_ops/traffic_ops_golang/routing/routes.go ########## @@ -354,6 +354,11 @@ func Routes(d ServerData) ([]Route, []RawRoute, http.Handler, error) { {1.3, http.MethodPut, `deliveryservices/{xmlID}/urisignkeys$`, urisigning.SaveDeliveryServiceURIKeysHandler, auth.PrivLevelAdmin, Authenticated, nil}, {1.3, http.MethodDelete, `deliveryservices/{xmlID}/urisignkeys$`, urisigning.RemoveDeliveryServiceURIKeysHandler, auth.PrivLevelAdmin, Authenticated, nil}, + //Delivery Service Required Capabilities: CRUD + {1.4, http.MethodGet, `deliveryservice_required_capabilities/?$`, api.ReadHandler(&deliveryservice.RequiredCapability{}), auth.PrivLevelReadOnly, Authenticated, nil}, Review comment: this should be deliveryservices_required_capabilities (missing s on deliveryservice) perhttps://github.com/apache/trafficcontrol/blob/master/blueprints/server-capabilitites.md#traffic-ops-impact ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services