mitchell852 commented on a change in pull request #4044: Ensure
server_capability can only be assigned to edges or mids
URL: https://github.com/apache/trafficcontrol/pull/4044#discussion_r341252016
##########
File path:
traffic_portal/app/src/common/modules/form/server/form.server.tpl.html
##########
@@ -34,8 +34,8 @@
<li><a ng-click="confirmStatusUpdate()">Update
Status</a></li>
<li ng-show="isCache(server) && !server.updPending"><a
ng-click="queueServerUpdates(server)">Queue Server Updates</a></li>
<li ng-show="isCache(server) && server.updPending"><a
ng-click="clearServerUpdates(server)">Clear Server Updates</a></li>
- <li ng-show="isEdge(server) || isCache(server)"
class="divider"></li>
- <li name="viewCapabilitiesMenuItem"><a
ng-click="viewCapabilities()">Manage Capabilities</a></li>
+ <li ng-show="isCache(server)" class="divider"></li>
+ <li ng-show="isCache(server)"
name="viewCapabilitiesMenuItem"><a ng-click="viewCapabilities()">Manage
Capabilities</a></li>
<li><a ng-click="viewDeliveryServices()">Manage Delivery
Services</a></li>
Review comment:
I guess the `viewDeliveryServices` menu item should have had the
`isEdge(server)` check because only edges can be assigned to delivery services.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
