ocket8888 commented on a change in pull request #3534: TP Delivery Service 
Generate SSL update, new letsencrypt generate and…
URL: https://github.com/apache/trafficcontrol/pull/3534#discussion_r341382173
 
 

 ##########
 File path: 
traffic_portal/app/src/common/modules/form/deliveryServiceSslKeys/form.deliveryServiceSslKeys.tpl.html
 ##########
 @@ -41,39 +41,53 @@
         <br>
 
 Review comment:
   Also also: when I manually reveal the menu by editing the styling in a dev 
console, I can click on "Generate SSL Keys" but strangely nothing happens. Dev 
console also indicates that there's no event listener attached to that node, 
which is odd because it does have an `ng-click` attribute...
   I have to guess that this is something related to your changes to the 
controller because on master this page works fine. Probably `generateKeys` 
couldn't be found and so no event listener was registered?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to