ocket8888 commented on a change in pull request #3996: Rewrote /user/current to
Go
URL: https://github.com/apache/trafficcontrol/pull/3996#discussion_r358942272
##########
File path: lib/go-tc/users.go
##########
@@ -86,10 +94,11 @@ type commonUserFields struct {
// User fields in v14 have been updated to be nullable
type User struct {
- Username *string `json:"username" db:"username"`
- RegistrationSent *TimeNoMod `json:"registrationSent"
db:"registration_sent"`
- LocalPassword *string `json:"localPasswd,omitempty"
db:"local_passwd"`
- RoleName *string `json:"roleName,omitempty" db:"-"`
+ Username *string `json:"username" db:"username"`
+ RegistrationSent *TimeNoMod `json:"registrationSent"
db:"registration_sent"`
+ LocalPassword *string `json:"localPasswd,omitempty"
db:"local_passwd"`
+ ConfirmLocalPassword *string `json:"confirmLocalPasswd,omitempty"
db:"confirm_local_passwd"`
Review comment:
So, Perl never checked that they matched but it *did* update it with a hash
of the passed value when it was present and not an empty string. I've made
updates so that it matches the Perl behavior by not checking that they match,
not checking that both are present when either one is, and updating it whenever
it's present and not empty. Is that acceptable?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
