mhoppa commented on issue #4203: TO: rewrite /isos to Go URL: https://github.com/apache/trafficcontrol/pull/4203#issuecomment-582643683 > > Should support for this endpoint be added to the client package? > > Hmm...maybe that's not really necessary unless you believe we need it for API integration tests. > > > Should the endpoint limit concurrency? Since the endpoint creates/updates files as part of the kickstart configuration, it's possible for multiple requests to interfere with each other. It might also be possible to copy the base kickstart files to a temp directory first, and then operate on that unique directory per request. I'm not sure if the Perl version has this issue -- depends on if requests can happen concurrently. > > Also a good question. I'm pretty sure Perl handles requests concurrently; Mojolicious handles each request in one of a pre-configured number of "worker" processes. How large are the files in question? Can they be copied to a temp dir quickly enough to keep the API reasonably quick? I looked into copying files into a temp directory that we are acting upon to solve this but one problem is the logic looks for a custom executable and it doesnt pass in the directory of the kickstart files we are modifying so it relies on that executable to know exactly where those files should live. With that and the fact that Perl handles requests concurrently making this not a new problem I say we leave it is implemented to avoid not breaking the custom executables that are out there.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
