ocket8888 commented on a change in pull request #4196: TP: Provides the ability
to view all users for a given role
URL: https://github.com/apache/trafficcontrol/pull/4196#discussion_r375545198
##########
File path: traffic_portal/app/src/common/modules/form/role/form.role.tpl.html
##########
@@ -25,7 +25,7 @@
</ol>
<div class="pull-right" role="group" ng-show="!settings.isNew">
<button class="btn btn-primary" title="View Capabilities"
ng-show="enforceCapabilities" ng-click="viewCapabilities()">View
Capabilities</button>
- <!--<button class="btn btn-primary" title="View Users"
ng-click="viewUsers()">View Users</button>-->
+ <button class="btn btn-primary" title="View Users"
ng-click="viewUsers()">View Users</button>
Review comment:
This button (and actually the above 'viewCapabilities' button too) is a
`button[type="submit"]`, should set `type` to `button`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
