ocket8888 commented on a change in pull request #4390: Remove methods marked as 
deprecated in 3.x
URL: https://github.com/apache/trafficcontrol/pull/4390#discussion_r377770952
 
 

 ##########
 File path: traffic_ops/testing/api/v1/tenants_test.go
 ##########
 @@ -263,24 +267,30 @@ func UpdateTestTenantsActive(t *testing.T) {
        // 2. tenant3user has tenant3.
        // 3. tenant2 is not a child of tenant3 (tenant3 is a child of tenant2)
        // 4. Therefore, tenant3user should not have access to ds2
-       dses, _, _ = tenant3Session.GetDeliveryServiceByXMLID("ds2")
+       dses, _, _ = tenant3Session.GetDeliveryServiceByXMLIDNullable("ds2")
        for _, ds := range dses {
-               t.Errorf("tenant3user got delivery service %+v with tenant2, 
expected: no ds", ds.XMLID)
+               if ds.XMLID != nil {
+                       t.Errorf("tenant3user got delivery service %+v with 
tenant2, expected: no ds", *ds.XMLID)
 
 Review comment:
   Same as above RE this is still an error

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to