ocket8888 commented on a change in pull request #4390: Remove methods marked as 
deprecated in 3.x
URL: https://github.com/apache/trafficcontrol/pull/4390#discussion_r377769338
 
 

 ##########
 File path: traffic_ops/testing/api/v1/steeringtargets_test.go
 ##########
 @@ -251,24 +260,28 @@ func DeleteTestSteeringTargets(t *testing.T) {
                        t.Error("deleting steering target: test data missing 
target")
                }
 
-               respDS, _, err := 
SteeringUserSession.GetDeliveryServiceByXMLID(string(*st.DeliveryService))
+               respDS, _, err := 
SteeringUserSession.GetDeliveryServiceByXMLIDNullable(string(*st.DeliveryService))
                if err != nil {
                        t.Errorf("deleting steering target: getting ds: %v", 
err)
                } else if len(respDS) < 1 {
                        t.Error("deleting steering target: getting ds: not 
found")
+               } else if respDS[0].ID == nil {
+                       t.Error("deleting steering target: getting ds: nil ID 
returned")
                }
-               dsID := uint64(respDS[0].ID)
+               dsID := uint64(*respDS[0].ID)
                st.DeliveryServiceID = &dsID
 
                dsIDs = append(dsIDs, dsID)
 
-               respTarget, _, err := 
SteeringUserSession.GetDeliveryServiceByXMLID(string(*st.Target))
+               respTarget, _, err := 
SteeringUserSession.GetDeliveryServiceByXMLIDNullable(string(*st.Target))
                if err != nil {
                        t.Errorf("deleting steering target: getting target ds: 
%v", err)
                } else if len(respTarget) < 1 {
                        t.Error("deleting steering target: getting target ds: 
not found")
+               } else if respDS[0].ID == nil {
+                       t.Error("deleting steering target: getting target ds: 
not found")
 
 Review comment:
   Same as above RE: fatal errors

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to