mhoppa commented on a change in pull request #4378: updated API to version 2.x
URL: https://github.com/apache/trafficcontrol/pull/4378#discussion_r377799821
##########
File path: traffic_ops/traffic_ops_golang/routing/routes.go
##########
@@ -614,7 +1056,7 @@ func Routes(d ServerData) ([]Route, []RawRoute,
http.Handler, error) {
// verify configured perl_routes are actually able to pass through to
Perl
perlRoutes := GetRouteIDMap(d.PerlRoutes)
for _, r := range routes {
- if _, isPerlRoute := perlRoutes[r.ID]; isPerlRoute &&
!r.CanBypassToPerl {
+ if _, isPerlRoute := perlRoutes[r.ID]; isPerlRoute &&
(!r.CanBypassToPerl || r.Version.Major > 2) { //do not allow any routes from
version 2.x and above to pass thorugh to Perl
Review comment:
should the major conditional be ```>=```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
