ocket8888 commented on a change in pull request #4390: Remove methods marked as
deprecated in 3.x
URL: https://github.com/apache/trafficcontrol/pull/4390#discussion_r377928575
##########
File path: traffic_ops/testing/api/v1/steeringtargets_test.go
##########
@@ -51,80 +51,87 @@ func SetupSteeringTargets(t *testing.T) {
func CreateTestSteeringTargets(t *testing.T) {
for _, st := range testData.SteeringTargets {
if st.Type == nil {
- t.Error("creating steering target: test data missing
type")
+ t.Fatal("creating steering target: test data missing
type")
}
if st.DeliveryService == nil {
- t.Error("creating steering target: test data missing
ds")
+ t.Fatal("creating steering target: test data missing
ds")
}
if st.Target == nil {
- t.Error("creating steering target: test data missing
target")
+ t.Fatal("creating steering target: test data missing
target")
}
{
respTypes, _, err :=
SteeringUserSession.GetTypeByName(*st.Type)
if err != nil {
- t.Errorf("creating steering target: getting
type: %v", err)
+ t.Fatalf("creating steering target: getting
type: %v", err)
} else if len(respTypes) < 1 {
- t.Error("creating steering target: getting
type: not found")
+ t.Fatal("creating steering target: getting
type: not found")
}
st.TypeID = util.IntPtr(respTypes[0].ID)
}
{
- respDS, _, err :=
SteeringUserSession.GetDeliveryServiceByXMLID(string(*st.DeliveryService))
+ respDS, _, err :=
SteeringUserSession.GetDeliveryServiceByXMLIDNullable(string(*st.DeliveryService))
if err != nil {
- t.Errorf("creating steering target: getting ds:
%v", err)
+ t.Fatalf("creating steering target: getting ds:
%v", err)
} else if len(respDS) < 1 {
- t.Error("creating steering target: getting ds:
not found")
+ t.Fatal("creating steering target: getting ds:
not found")
+ } else if respDS[0].ID == nil {
+ t.Fatal("creating steering target: getting ds:
nil ID returned")
}
- dsID := uint64(respDS[0].ID)
+ dsID := uint64(*respDS[0].ID)
st.DeliveryServiceID = &dsID
}
{
- respTarget, _, err :=
SteeringUserSession.GetDeliveryServiceByXMLID(string(*st.Target))
+ respTarget, _, err :=
SteeringUserSession.GetDeliveryServiceByXMLIDNullable(string(*st.Target))
if err != nil {
- t.Errorf("creating steering target: getting
target ds: %v", err)
+ t.Fatalf("creating steering target: getting
target ds: %v", err)
} else if len(respTarget) < 1 {
- t.Error("creating steering target: getting
target ds: not found")
+ t.Fatal("creating steering target: getting
target ds: not found")
+ } else if respTarget[0].ID == nill {
Review comment:
> `nill`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
