rob05c commented on a change in pull request #4142: Allow IPv6 Only Caches,
including monitoring and routing
URL: https://github.com/apache/trafficcontrol/pull/4142#discussion_r379043530
##########
File path: traffic_monitor/manager/manager.go
##########
@@ -45,6 +46,8 @@ import (
func Start(opsConfigFile string, cfg config.Config, appData
config.StaticAppData, trafficMonitorConfigFileName string) error {
toSession :=
towrap.ITrafficOpsSession(towrap.NewTrafficOpsSessionThreadsafe(nil,
cfg.CRConfigHistoryCount, cfg))
+ url6Regex := regexp.MustCompile(`/\d+`)
Review comment:
It isn't. But that's not a bad idea, might be worth looking into. I don't
know how the cost of parsing the IP compares to the request cost; but we do
enough requests, and use enough CPU, it might be significant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
