ocket8888 opened a new pull request #4414: Go client upgrade URL: https://github.com/apache/trafficcontrol/pull/4414 ## What does this PR (Pull Request) do? - [x] This PR is not related to any Issue Upgrades the Go client to use TO API v2. The old v1 client is now available in `traffic_ops/v1-client/` and the v1 API/client integration tests have been updated to import it properly from that path. This PR also came with a few improved GoDocs, and a consistent format for constants that hold API routes e.g. API_ABOUT instead of API_v13_About or API_v3_ABOUT or case transformations thereof. Which isn't to say all files use these constants, just that those that do use the consistent naming. This PR also removes client methods for endpoints that don't exist in API v2 (not from the v1 client). ## Which Traffic Control components are affected by this PR? - Traffic Control Client (Go), and therefore: - Grove - Traffic Monitor - Traffic Ops ORT (ATSTCCFG) - Traffic Stats ## What is the best way to verify this PR? Run all of the applicable Go unit tests, run the client v1 API/integration tests, run the individual affected components and make sure they can still reach and parse the data they need. ## The following criteria are ALL met by this PR - [x] Tests will be added in #4374 - [x] GoDocs make the client self-documenting - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary - [x] This PR includes any and all required license headers - [x] This PR does not include a database migration - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY**
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
