alficles commented on a change in pull request #4419: ORT Speed Improvements
URL: https://github.com/apache/trafficcontrol/pull/4419#discussion_r382265091
##########
File path: traffic_ops/ort/traffic_ops_ort.pl
##########
@@ -1847,7 +1855,12 @@ sub get_cfg_file_list {
my $cdn_name;
my $uri = "/api/1.4/servers/$host_name/configfiles/ats";
+ # Telling atstccfg to use-cache=false will cause it to delete the cache
directory
+ # Which is what we want: when ORT starts to run, delete the cache. We
only want to use the atstccfg cache within the same ORT run, not across
different runs.
Review comment:
So, this only works because this is the first request of the run. If someone
adds a call before this at some point, they could easily wind up introducing a
very subtle race condition. It would be nice to see this a bit more robust?
Maybe a global clear-cache flag that is checked and set by lwp_get itself that
would run on first call regardless of what that was?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
