ocket8888 commented on a change in pull request #4415: Updated Traffic Portal
to use TO API v2.0
URL: https://github.com/apache/trafficcontrol/pull/4415#discussion_r384200789
##########
File path:
traffic_portal/app/src/common/modules/widget/dashboardStats/widget.dashboardStats.tpl.html
##########
@@ -19,43 +19,43 @@
<div class="col-md-4 col-sm-6 col-xs-12">
<div class="col-md-6 col-sm-12 col-xs-12 tile_stats_count current">
- <span class="count_top">Current Bandwidth</span>
- <div class="count">{{totalBandwidth}}</div>
+ <label for="totalBandwidth" class="count_top">Current Bandwidth</label>
+ <output id="totalBandwidth" class="count">{{totalBandwidth}}</output>
</div>
<div class="col-md-6 col-sm-12 col-xs-12 tile_stats_count current">
- <span class="count_top">Current Connections</span>
- <div class="count">{{totalConnections}}</div>
+ <label for="totalConnections" class="count_top">Current
Connections</label>
+ <output id="totalConnections"
class="count">{{totalConnections}}</output>
</div>
</div>
<div class="col-md-8 col-sm-6 col-xs-12">
<div class="col-md-4 col-sm-12 col-xs-12 tile_stats_count">
<div class="col-md-6 col-sm-6 col-xs-6">
- <span class="count_top"><a
ng-click="navigateToPath('/cache-stats')">Healthy Caches</a></span>
- <div class="count green">{{totalOnline}}</div>
+ <label for="totalOnline" class="count_top"><a
ng-click="navigateToPath('/cache-stats')">Healthy Caches</a></label>
+ <output id="totalOnline" class="count
green">{{totalOnline}}</output>
</div>
<div class="col-md-6 col-sm-6 col-xs-6">
- <span class="count_top"><a
ng-click="navigateToPath('/cache-stats')">Unhealthy Caches</a></span>
- <div class="count red">{{totalOffline}}</div>
+ <label for="totaloffline" class="count_top"><a
ng-click="navigateToPath('/cache-stats')">Unhealthy Caches</a></label>
+ <output id="totalOffline" class="count
red">{{totalOffline}}</output>
</div>
</div>
<div class="col-md-4 col-sm-12 col-xs-12 tile_stats_count">
<div class="col-md-6 col-sm-6 col-xs-6">
- <span class="count_top">Online Caches</span>
- <div class="count">{{online()}}</div>
+ <label for="online-caches" class="count_top">Online Caches</label>
+ <output id="online-caches" class="count">{{online()}}</output>
Review comment:
but it said `{{online()}}` before? If I do `{{online}}` it'll say something
like `function online()` in the output.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
