rawlinp opened a new pull request #4469: TP: Format DNSSEC keys effectiveDate in RCF3339 format URL: https://github.com/apache/trafficcontrol/pull/4469 ## What does this PR (Pull Request) do? Currently, TP is formatting the effectiveDate field in the request as unix epoch in MILLISECONDS. TO API expects epoch time format to be in SECONDS. This means that TO creates DNSSEC keys with an effective date ridiculously far into the future, when it was meant for the effective date to be "now". Alternatively, just format it as RFC3339, which the TO API can also parse. - [x] This PR is not related to any Issue ## Which Traffic Control components are affected by this PR? - Traffic Portal ## What is the best way to verify this PR? Without this PR installed, in Traffic Portal open the developer console and generate CDN DNSSEC keys. Verify that the `effectiveDate` field sent in the request to TO is formatted as a unix epoch time -- e.g. `"1583439180411"`. With the PR installed, do the same thing but verify the time is formatted in RFC3339 format -- e.g. `"2020-03-05T20:57:00Z"`. ## If this is a bug fix, what versions of Traffic Control are affected? - master - 4.0.x ## The following criteria are ALL met by this PR - [ ] This PR includes tests OR I have explained why tests are unnecessary - [x] Bugfix, no docs necessary - [x] This PR includes an update to CHANGELOG.md - [x] This PR includes any and all required license headers - [x] This PR does not include a database migration - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
