mattjackson220 commented on a change in pull request #4470: Deprecate keys/ping
URL: https://github.com/apache/trafficcontrol/pull/4470#discussion_r390511495
##########
File path: traffic_ops/traffic_ops_golang/ping/keys.go
##########
@@ -20,25 +20,29 @@ package ping
*/
import (
- "errors"
+ "github.com/apache/trafficcontrol/lib/go-tc"
"net/http"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/api"
"github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/riaksvc"
)
func Keys(w http.ResponseWriter, r *http.Request) {
+ alerts := tc.CreateAlerts(tc.WarnLevel, "This endpoint is deprecated")
Review comment:
since this is being deprecated because the `/riak/ping` endpoint did the
same what do you think about putting in an alternative for this like we did
when we moved that one? `"text": "This endpoint is deprecated, please use GET
/api/2.0/vault/ping instead"`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
