ZugNZwang opened a new issue #4480: POST request to /letsencrypt/autorenew results in traffic ops failure URL: https://github.com/apache/trafficcontrol/issues/4480 <!-- ************ STOP!! ************ If this issue identifies a security vulnerability, DO NOT submit it! Instead, contact the Apache Software Foundation Security Team at [email protected] and follow the guidelines at https://www.apache.org/security/ regarding vulnerability disclosure. --> <!-- - For *SUPPORT QUESTIONS*, use the [Traffic Control slack channels](https://traffic-control-cdn.slack.com) or [Traffic Control mailing lists](http://trafficcontrol.apache.org/mailing_lists/). - Before submitting, please **SEARCH GITHUB** for a similar issue or PR. --> ## I'm submitting a ... <!-- (check all that apply with "[x]") --> <!--- security vulnerability (STOP!! - see above)--> - [X] bug report - [ ] new feature / enhancement request - [ ] improvement request (usability, performance, tech debt, etc.) - [ ] other <!--(Please do not submit support requests here - see above)--> ## Traffic Control components affected ... <!-- (check all that apply with "[x]") --> - [ ] CDN in a Box - [ ] Documentation - [ ] Grove - [ ] Traffic Control Client - [ ] Traffic Monitor - [X] Traffic Ops - [ ] Traffic Ops ORT - [ ] Traffic Portal - [ ] Traffic Router - [ ] Traffic Stats - [ ] Traffic Vault - [ ] unknown ## Current behavior: <!-- Describe how the bug manifests / how the current features are insufficient. --> When making a `POST` request to `letsencrypt/autorenew` (empty request body) results in traffic ops failing with the following status: ``` Mar 10 20:24:11 ...: panic: runtime error: invalid memory address or nil pointer dereference Mar 10 20:24:11 ...: [signal SIGSEGV: segmentation violation code=0x1 addr=0x18 pc=0xa8926c] Mar 10 20:24:11 ...: goroutine 239953 [running]: Mar 10 20:24:11 ...: github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice.RunAutorenewal(0xc0010f4080, 0x3, 0x4, 0xc000196480, 0xee6700, 0xc000c99a40, 0xc00109f950) Mar 10 20:24:11 ...: /tmp/go/src/github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice/autorenewcerts.go:194 +0x29c Mar 10 20:24:11 ...: created by github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice.RenewCertificates Mar 10 20:24:11 ...: /tmp/go/src/github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/deliveryservice/autorenewcerts.go:92 +0x4a7 ``` ## Expected / new behavior: <!-- Describe what the behavior would be without the bug / how the feature would improve Traffic Control --> Should not bring down traffic ops ## Minimal reproduction of the problem with instructions: <!-- If the current behavior is a bug or you can illustrate your feature request better with an example, please provide the *STEPS TO REPRODUCE* and include the applicable TC version. --> ## Anything else: <!-- e.g. stacktraces, related issues, suggestions how to fix --> <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. -->
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
