mattjackson220 commented on a change in pull request #4477: Deprecate
parameters/profile/:name
URL: https://github.com/apache/trafficcontrol/pull/4477#discussion_r391036166
##########
File path:
traffic_ops/traffic_ops_golang/profileparameter/parameterprofilebyname.go
##########
@@ -31,11 +31,16 @@ import (
func GetProfileName(w http.ResponseWriter, r *http.Request) {
inf, userErr, sysErr, errCode := api.NewInfo(r, []string{"name"}, nil)
if userErr != nil || sysErr != nil {
- api.HandleErr(w, r, inf.Tx.Tx, errCode, userErr, sysErr)
+ api.HandleDeprecatedErr(w, r, nil, errCode, userErr, sysErr,
nil)
Review comment:
so this function is actually used for this endpoint and the
`profiles/name/{name}/parameters` endpoint which is the alternative for this
after its deprecated. we will have to split that up so that the alternative
doesnt also get the deprecation notice
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
