mhoppa commented on a change in pull request #4524: Fix TO unit tests
URL: https://github.com/apache/trafficcontrol/pull/4524#discussion_r395120487
##########
File path: traffic_ops/traffic_ops_golang/types/types_test.go
##########
@@ -172,11 +172,11 @@ func TestCreateInvalidType(t *testing.T) {
func TestDeleteInvalidType(t *testing.T) {
invalidDeleteType := createDummyType("other")
- _, err, statusCode := invalidDeleteType.Delete()
+ err, _, statusCode := invalidDeleteType.Delete()
if err == nil {
t.Fatalf("expected delete type to have an error")
}
- if statusCode != http.StatusBadRequest {
+ if statusCode != http.StatusNotFound {
t.Fatalf("expected delete type to return a 400 error")
Review comment:
this error should been updated to "expected delete type to return a 404
error"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
