mhoppa commented on a change in pull request #4518: Add service category 
feature to TO and TP
URL: https://github.com/apache/trafficcontrol/pull/4518#discussion_r395147067
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/deliveryservice/deliveryservices.go
 ##########
 @@ -184,6 +183,29 @@ func CreateV15(w http.ResponseWriter, r *http.Request) {
        api.WriteRespAlertObj(w, r, tc.SuccessLevel, "Deliveryservice creation 
was successful.", []tc.DeliveryServiceNullableV15{*res})
 }
 
+//     TODO allow users to post names (type, cdn, etc) and get the IDs from 
the names. This isn't trivial to do in a single query, without dynamically 
building the entire insert query, and ideally inserting would be one query. But 
it'd be much more convenient for users. Alternatively, remove IDs from the 
database entirely and use real candidate keys.
+func CreateV16(w http.ResponseWriter, r *http.Request) {
 
 Review comment:
   This should be v20. V16 is non existent

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to