mhoppa commented on a change in pull request #4538: Deprecate 
steering/:ds/targets/:target 
URL: https://github.com/apache/trafficcontrol/pull/4538#discussion_r398065431
 
 

 ##########
 File path: traffic_ops/traffic_ops_golang/routing/routes.go
 ##########
 @@ -957,7 +956,7 @@ func Routes(d ServerData) ([]Route, []RawRoute, 
http.Handler, error) {
                {api.Version{1, 1}, http.MethodGet, 
`deliveryservices/{id}/health/?(\.json)?$`, deliveryservice.GetHealth, 
auth.PrivLevelReadOnly, Authenticated, nil, 2034590101, perlBypass},
 
                {api.Version{1, 1}, http.MethodGet, 
`steering/{deliveryservice}/targets/?(\.json)?$`, 
api.ReadHandler(&steeringtargets.TOSteeringTargetV11{}), 
auth.PrivLevelReadOnly, Authenticated, nil, 1569607824, noPerlBypass},
-               {api.Version{1, 1}, http.MethodGet, 
`steering/{deliveryservice}/targets/{target}$`, 
api.ReadHandler(&steeringtargets.TOSteeringTargetV11{}), 
auth.PrivLevelReadOnly, Authenticated, nil, 105995848, noPerlBypass},
+               {api.Version{1, 1}, http.MethodGet, 
`steering/{deliveryservice}/targets/{target}$`, 
api.DeprecatedReadHandler(&steeringtargets.TOSteeringTargetV11{}, nil), 
auth.PrivLevelReadOnly, Authenticated, nil, 105995848, noPerlBypass},
 
 Review comment:
   is the replacement route the base path `steering/{deliveryservice}/targets` 
with a query parameter of ID ?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to