mitchell852 commented on a change in pull request #4528: Deprecate
users/{userId}/deliveryServices
URL: https://github.com/apache/trafficcontrol/pull/4528#discussion_r399392356
##########
File path:
traffic_portal/app/src/common/modules/form/user/FormUserController.js
##########
@@ -50,7 +50,7 @@ var FormUserController = function(user, $scope, $location,
formUtils, stringUtil
$scope.labelize = stringUtils.labelize;
$scope.viewDeliveryServices = function() {
- $location.path($location.path() + '/delivery-services');
+ $location.path('/tenants/' + userModel.user.tenantId +
'/delivery-services');
Review comment:
So what this does is it directs you to the logged in user's tenant delivery
services page every time which is not what you want. You want this to direct
you to the user that was clicked's delivery services page.
For example, if i'm on the this page: https://tp.domain.com/#!/users/244,
then clicking "view delivery services" should direct me to
`$location.path('/tenants/' + user[244].tenantId + '/delivery-services');`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services