See 
<https://builds.apache.org/job/trafficcontrol-PR/5894/display/redirect?page=changes>

Changes:

[ocket8888] Reworked GET /servers for new interfaces table

[ocket8888] Updated query

[ocket8888] Simplified V2 server conversion

[ocket8888] Finally got GET working

[ocket8888] Implemented POST

[ocket8888] Implemented DELETE

[ocket8888] Added netmask parsing and changelogs

[ocket8888] Added method for converting legacy data to interface arrays

[ocket8888] Implemented PUT

[ocket8888] Fixed a couple unit tests

[ocket8888] Finished fixing unit tests

[ocket8888] Cleaned up old approaches left in comments

[ocket8888] Fixed server teardown for v1 tests

[ocket8888] Fixed broken POST handler for API versions < 3

[ocket8888] Fixed read query not returning IDs

[ocket8888] fixed unmarshaling problems, some API tests

[ocket8888] Fixed ip_allow.config for server interfaces

[ocket8888] Fixed PUT not returning proper names

[ocket8888] Fixed using unitialized data in PUT 1.1/servers handler

[ocket8888] Fixed/improved error messages

[ocket8888] Fixed select query

[ocket8888] Fixed downgraded servers not setting ipIsService and ip6IsService

[ocket8888] Fixed GET v1 servers returning v2 servers and vice-versa

[ocket8888] Changed responses to reference new API version, updated old client

[ocket8888] Updated client to send/return new server structure

[ocket8888] Changed tc-fixtures to use new server objects

[ocket8888] made TS use v2 client

[ocket8888] Fixed teardowns

[ocket8888] Fixed importing wrong client

[ocket8888] Fixed renaming a struct which breaks a vendored version of the 
client

[ocket8888] Fixed bad error message in v3 validation

[ocket8888] Fixed possible segfault in test failure state

[ocket8888] Fixed null response for no servers

[ocket8888] Fixed v3 tests for new server model

[ocket8888] Fixed possible nil panics from unitialized maps

[ocket8888] Added unit tests for server handler

[ocket8888] Added test for ToInterfaces method

[ocket8888] Go fmt

[ocket8888] Rolled back cdn.conf changes

[ocket8888] Rolled back database.conf changes

[ocket8888] Rolled back a change to ATSTCCFG that snuck in

[ocket8888] Removed unnecessary log

[ocket8888] Removed extra DELETE statement

[ocket8888] Removed unnecessary log

[ocket8888] Removed unnecessary log

[ocket8888] Removed unnecessary log

[ocket8888] Removed unused import

[ocket8888] Updated docs for /servers in v3

[ocket8888] updated servers/{{ID}} docs for v3

[ocket8888] Fixed broken footnote reference

[ocket8888] Fixed a ton of context-insensitive match warnings in Sphinx v3+

[ocket8888] Added response structure for DELETE /servers/{{ID}}

[ocket8888] Added summary field descriptions

[ocket8888] Updated CHANGELOG

[ocket8888] Proper capitalization of IP in ServerIPAddress

[ocket8888] s/ServersResponsev3/ServersV3Response/g

[ocket8888] Unset netmask when not present

[ocket8888] Short-circuit eval for interface-to-legacy conversion

[ocket8888] Removed ip_allow.config, remap.config, and parent.config v1 
generation

[ocket8888] Removed tests for now-non-existent routes

[ocket8888] Added deprecation notices to docs

[ocket8888] Updated changelog

[ocket8888] ACTUALLY removed tests for removed endpoints

[ocket8888] Reworked snapshots to use server interfaces

[ocket8888] Fixed typo in query


------------------------------------------
[...truncated 3.16 MB...]
unit_1  |     
TestGetImportProfile/Failure:_Import_profile_didn't_insert_row: 
profile_import_test.go:86: Starting test scenario:  Failure: Import profile 
didn't insert row
unit_1  | === RUN   
TestGetImportProfile/Failure:_Import_profile_storage_error
unit_1  |     
TestGetImportProfile/Failure:_Import_profile_storage_error: 
profile_import_test.go:86: Starting test scenario:  Failure: Import profile 
storage error
unit_1  | --- PASS: TestGetImportProfile (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfile/Success:_Import_profile_successful (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfile/Failure:_Import_profile_didn't_insert_row (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfile/Failure:_Import_profile_storage_error (0.00s)
unit_1  | === RUN   TestGetImportProfileParameters
unit_1  | === RUN   
TestGetImportProfileParameters/Success:_All_import_parameters_new
unit_1  |     
TestGetImportProfileParameters/Success:_All_import_parameters_new: 
profile_import_test.go:292: Starting test scenario:  Success: All import 
parameters new
unit_1  | === RUN   
TestGetImportProfileParameters/Success:_All_parameters_exisiting
unit_1  |     
TestGetImportProfileParameters/Success:_All_parameters_exisiting: 
profile_import_test.go:292: Starting test scenario:  Success: All parameters 
exisiting
unit_1  | === RUN   
TestGetImportProfileParameters/Success:_Mix_of_existing/new_parameters
unit_1  |     
TestGetImportProfileParameters/Success:_Mix_of_existing/new_parameters: 
profile_import_test.go:292: Starting test scenario:  Success: Mix of 
existing/new parameters
unit_1  | === RUN   
TestGetImportProfileParameters/Success:_Dup_of_existing
unit_1  |     TestGetImportProfileParameters/Success:_Dup_of_existing: 
profile_import_test.go:292: Starting test scenario:  Success: Dup of existing
unit_1  | === RUN   
TestGetImportProfileParameters/Fail:_Storage_error_selecting_param
unit_1  |     
TestGetImportProfileParameters/Fail:_Storage_error_selecting_param: 
profile_import_test.go:292: Starting test scenario:  Fail: Storage error 
selecting param
unit_1  | === RUN   
TestGetImportProfileParameters/Fail:_Storage_error_inserting_param
unit_1  |     
TestGetImportProfileParameters/Fail:_Storage_error_inserting_param: 
profile_import_test.go:292: Starting test scenario:  Fail: Storage error 
inserting param
unit_1  | --- PASS: TestGetImportProfileParameters (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfileParameters/Success:_All_import_parameters_new (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfileParameters/Success:_All_parameters_exisiting (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfileParameters/Success:_Mix_of_existing/new_parameters (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfileParameters/Success:_Dup_of_existing (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfileParameters/Fail:_Storage_error_selecting_param (0.00s)
unit_1  |     --- PASS: 
TestGetImportProfileParameters/Fail:_Storage_error_inserting_param (0.00s)
unit_1  | === RUN   TestGetProfiles
unit_1  | --- PASS: TestGetProfiles (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | === RUN   TestValidate
unit_1  | --- PASS: TestValidate (0.00s)
unit_1  | PASS
unit_1  | coverage: 52.6% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/profile 0.022s  
coverage: 52.6% of statements
unit_1  | === RUN   TestGetProfileParameters
unit_1  | --- PASS: TestGetProfileParameters (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | PASS
unit_1  | coverage: 2.3% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/profileparameter
        0.018s  coverage: 2.3% of statements
unit_1  | === RUN   TestReadRegions
unit_1  | --- PASS: TestReadRegions (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | PASS
unit_1  | coverage: 9.6% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/region  0.016s  
coverage: 9.6% of statements
unit_1  | === RUN   TestFetchObjectValues
unit_1  | --- PASS: TestFetchObjectValues (0.00s)
unit_1  | === RUN   TestSaveObject
unit_1  | --- PASS: TestSaveObject (0.00s)
unit_1  | === RUN   TestDeleteObject
unit_1  | --- PASS: TestDeleteObject (0.00s)
unit_1  | === RUN   TestSetTLSVersion
unit_1  | --- PASS: TestSetTLSVersion (0.00s)
unit_1  | === RUN   TestGetRiakCluster
unit_1  | --- PASS: TestGetRiakCluster (0.09s)
unit_1  | PASS
unit_1  | coverage: 18.3% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/riaksvc 0.112s  
coverage: 18.3% of statements
unit_1  | === RUN   TestFuncs
unit_1  | --- PASS: TestFuncs (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | === RUN   TestValidate
unit_1  | --- PASS: TestValidate (0.00s)
unit_1  | PASS
unit_1  | coverage: 10.6% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/role    0.017s  
coverage: 10.6% of statements
unit_1  | === RUN   TestCompileRoutes
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
api/1.1/cdns
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path 
POST api/1.4/users/login
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path 
POST api/1.1/cdns
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path 
POST api/1.1/users
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path PUT 
api/1.1/deliveryservices/3
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path 
DELETE api/1.1/servers/777
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
api/1.4/cdns/1
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
api/1.4/notatypeweknowabout
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
api/1.3/asns.json
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
api/99999.99999/cdns
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
blahblah/api/1.2/cdns
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
internal/api/1.2/federations.json
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
api/1.5/servers
unit_1  |     TestCompileRoutes: routing_test.go:162: testing path GET 
api/2.0/servers
unit_1  | --- PASS: TestCompileRoutes (0.07s)
unit_1  | === RUN   TestRoutes
unit_1  | --- PASS: TestRoutes (0.00s)
unit_1  | === RUN   TestCreateRouteMap
unit_1  | --- PASS: TestCreateRouteMap (0.00s)
unit_1  | PASS
unit_1  | coverage: 47.9% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/routing 0.098s  
coverage: 47.9% of statements
unit_1  | === RUN   TestWrapHeaders
unit_1  | --- PASS: TestWrapHeaders (0.00s)
unit_1  | === RUN   TestWrapPanicRecover
unit_1  | --- PASS: TestWrapPanicRecover (0.00s)
unit_1  | === RUN   TestGzip
unit_1  | --- PASS: TestGzip (0.00s)
unit_1  | === RUN   TestWrapAuth
unit_1  | --- PASS: TestWrapAuth (0.00s)
unit_1  | PASS
unit_1  | coverage: 52.4% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/routing/middleware
      0.018s  coverage: 52.4% of statements
unit_1  | === RUN   TestAssignDsesToServer
unit_1  | --- PASS: TestAssignDsesToServer (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | === RUN   TestGetServersByCachegroup
unit_1  | --- PASS: TestGetServersByCachegroup (0.00s)
unit_1  | === RUN   TestGetMidServers
unit_1  |     TestGetMidServers: servers_test.go:380: getMidServers 
expected: Type == MID, actual: EDGE
unit_1  | --- FAIL: TestGetMidServers (0.00s)
unit_1  | === RUN   TestV3Validations
unit_1  |     TestV3Validations: servers_test.go:450: Got expected 
error validating server with no interfaces: a server must have at least one 
interface
unit_1  |     TestV3Validations: servers_test.go:462: Got expected 
error validating server with nil interfaces: a server must have at least one 
interface
unit_1  |     TestV3Validations: servers_test.go:477: Got expected 
error validating server with an MTU < 1280: type not found, associated profile 
must have a cdn associated
unit_1  |     TestV3Validations: servers_test.go:491: Got expected 
error validating server with no IP addresses: 'interface 'eth0' ipAddresses' 
cannot be blank, type not found, associated profile must have a cdn associated
unit_1  |     TestV3Validations: servers_test.go:504: Got expected 
error validating server with nil IP addresses: 'interface 'eth0' ipAddresses' 
cannot be blank, type not found, associated profile must have a cdn associated
unit_1  |     TestV3Validations: servers_test.go:523: Got expected 
error validating server with no service addresses: type not found, associated 
profile must have a cdn associated
unit_1  |     TestV3Validations: servers_test.go:535: Got expected 
error validating server with too many interfaces with service addresses: 
interfaces: address '127.0.0.1/32' of interface 'eth0' is marked as a service 
address, but an IPv4 service address appears earlier in the list, type not 
found, associated profile must have a cdn associated
unit_1  |     TestV3Validations: servers_test.go:553: Got expected 
error validating server with no service addresses: interfaces: address 
'1.2.3.4/1' of interface 'eth0' is marked as a service address, but an IPv4 
service address appears earlier in the list, type not found, associated profile 
must have a cdn associated
unit_1  | --- PASS: TestV3Validations (0.00s)
unit_1  | === RUN   TestGetServerUpdateStatus
unit_1  | --- PASS: TestGetServerUpdateStatus (0.00s)
unit_1  | FAIL
unit_1  | coverage: 14.8% of statements
unit_1  | FAIL 
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/server  0.025s
unit_1  | FAIL
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/servercapability
        [no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/servercheck     
[no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/servercheck/extensions
  [no test files]
unit_1  | === RUN   TestFuncs
unit_1  | --- PASS: TestFuncs (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | === RUN   TestValidate
unit_1  | --- PASS: TestValidate (0.00s)
unit_1  | PASS
unit_1  | coverage: 34.1% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/staticdnsentry  
0.017s  coverage: 34.1% of statements
unit_1  | === RUN   TestReadStatuses
unit_1  | --- PASS: TestReadStatuses (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | PASS
unit_1  | coverage: 28.9% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/status  0.016s  
coverage: 28.9% of statements
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/steering        
[no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/steeringtargets 
[no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/swaggerdocs/v13 
[no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/swaggerdocs/v13/swaggerspec-server
      [no test files]
unit_1  | === RUN   TestGetSystemInfo
unit_1  | --- PASS: TestGetSystemInfo (0.00s)
unit_1  | PASS
unit_1  | coverage: 57.1% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/systeminfo      
0.016s  coverage: 57.1% of statements
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tenant  [no 
test files]
unit_1  | === RUN   TestErrorCode
unit_1  | --- PASS: TestErrorCode (0.00s)
unit_1  | === RUN   TestErrorContextPanicMode
unit_1  | --- PASS: TestErrorContextPanicMode (0.00s)
unit_1  | === RUN   TestErrorContextMapping
unit_1  | --- PASS: TestErrorContextMapping (0.00s)
unit_1  | === RUN   TestErrorContextMisc
unit_1  | --- PASS: TestErrorContextMisc (0.00s)
unit_1  | === RUN   TestErrorContext
unit_1  | --- PASS: TestErrorContext (0.00s)
unit_1  | === RUN   TestColsFromStructByTag
unit_1  | --- PASS: TestColsFromStructByTag (0.00s)
unit_1  | PASS
unit_1  | coverage: 80.2% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/test    0.005s  
coverage: 80.2% of statements
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/tocookie        
[no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/topology        
[no test files]
unit_1  | === RUN   TestTSConfigFromRequest
unit_1  | --- PASS: TestTSConfigFromRequest (0.00s)
unit_1  | PASS
unit_1  | coverage: 4.4% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/trafficstats    
0.017s  coverage: 4.4% of statements
unit_1  | === RUN   TestGetType
unit_1  | --- PASS: TestGetType (0.00s)
unit_1  | === RUN   TestInterfaces
unit_1  | --- PASS: TestInterfaces (0.00s)
unit_1  | === RUN   TestUpdateInvalidType
unit_1  | --- PASS: TestUpdateInvalidType (0.00s)
unit_1  | === RUN   TestDeleteInvalidType
unit_1  | --- PASS: TestDeleteInvalidType (0.00s)
unit_1  | === RUN   TestCreateInvalidType
unit_1  | --- PASS: TestCreateInvalidType (0.00s)
unit_1  | === RUN   TestValidate
unit_1  | --- PASS: TestValidate (0.00s)
unit_1  | PASS
unit_1  | coverage: 40.3% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/types   0.015s  
coverage: 40.3% of statements
unit_1  | === RUN   TestValidateURIKeyset
unit_1  | --- PASS: TestValidateURIKeyset (0.00s)
unit_1  | PASS
unit_1  | coverage: 14.5% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/urisigning      
0.014s  coverage: 14.5% of statements
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/user    [no 
test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/util/monitorhlp 
[no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/traffic_ops_golang/vault   [no 
test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg       [no test files]
unit_1  | === RUN   TestWriteConfigs
unit_1  | --- PASS: TestWriteConfigs (0.00s)
unit_1  | === RUN   TestPreprocessConfigFile
unit_1  | --- PASS: TestPreprocessConfigFile (0.00s)
unit_1  | === RUN   TestGetDSFromURISigningConfigFileName
unit_1  | --- PASS: TestGetDSFromURISigningConfigFileName (0.00s)
unit_1  | === RUN   TestGetDSFromURLSigConfigFileName
unit_1  | --- PASS: TestGetDSFromURLSigConfigFileName (0.00s)
unit_1  | PASS
unit_1  | coverage: 2.6% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/cfgfile       0.021s  
coverage: 2.6% of statements
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/config        [no 
test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/getdata       [no 
test files]
unit_1  | === RUN   TestPlugin
unit_1  | --- PASS: TestPlugin (0.00s)
unit_1  | PASS
unit_1  | coverage: 48.9% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/plugin        0.016s  
coverage: 48.9% of statements
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/toreq [no test files]
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/toreqnew      [no 
test files]
unit_1  | === RUN   TestGetRetry
unit_1  | --- PASS: TestGetRetry (3.00s)
unit_1  | === RUN   TestRetryBackoffSeconds
unit_1  | --- PASS: TestRetryBackoffSeconds (0.00s)
unit_1  | === RUN   TestMaybeIPStr
unit_1  | --- PASS: TestMaybeIPStr (0.00s)
unit_1  | PASS
unit_1  | coverage: 57.1% of statements
unit_1  | ok   
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/torequtil     3.006s  
coverage: 57.1% of statements
unit_1  | ?    
github.com/apache/trafficcontrol/traffic_ops/ort/atstccfg/update-to-client      
[no test files]
trafficcontrol-pr_unit_1 exited with code 1
Aborting on container exit...
+ exit 1
+ finish
+ local st=1
+ [[ 1 -ne 0 ]]
+ echo 'Exiting with status 1'
Exiting with status 1
+ <https://builds.apache.org/job/trafficcontrol-PR/ws/bin/docker-compose> -p 
trafficcontrol-PR -f tools/golang/docker-compose.yml down -v
Removing trafficcontrol-pr_unit_1 ... 
Removing trafficcontrol-pr_unit_1 ... doneRemoving network 
trafficcontrol-pr_default
Build step 'Execute shell' marked build as failure
Skipped archiving because build is not successful

Reply via email to