rawlinp commented on a change in pull request #4107:
URL: https://github.com/apache/trafficcontrol/pull/4107#discussion_r432032085
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java
##########
@@ -479,13 +479,13 @@ private static void generateZones(final TrafficRouter tr,
final LoadingCache<Zon
final Name name = newName(domain);
final List<Record> list = zoneMap.get(domain);
final Name admin = newName(ZoneUtils.getAdminString(soa,
"admin", "traffic_ops", domain));
- list.add(new SOARecord(name, DClass.IN,
- ZoneUtils.getLong(ttl, "SOA", 86400),
getGlueName(ds, trafficRouters.get(hostname), name, hostname), admin,
Review comment:
this one too please
##########
File path:
traffic_router/core/src/main/java/com/comcast/cdn/traffic_control/traffic_router/core/dns/ZoneManager.java
##########
@@ -673,7 +673,7 @@ private static void addStaticDnsEntries(final List<Record>
list, final DeliveryS
@SuppressWarnings("PMD.CyclomaticComplexity")
private static void addTrafficRouters(final List<Record> list, final
JsonNode trafficRouters, final Name name,
- final JsonNode ttl, final String domain, final
DeliveryService ds)
Review comment:
this one too please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
