mitchell852 opened a new issue #4740:
URL: https://github.com/apache/trafficcontrol/issues/4740
## I'm submitting a ...
<!-- (check all that apply with "[x]") -->
<!--- security vulnerability (STOP!! - see above)-->
- [x] bug report
- [ ] new feature / enhancement request
- [ ] improvement request (usability, performance, tech debt, etc.)
- [ ] other <!--(Please do not submit support requests here - see above)-->
## Traffic Control components affected ...
<!-- (check all that apply with "[x]") -->
- [ ] CDN in a Box
- [ ] Documentation
- [ ] Grove
- [ ] Traffic Control Client
- [ ] Traffic Monitor
- [x] Traffic Ops
- [ ] Traffic Ops ORT
- [ ] Traffic Portal
- [ ] Traffic Router
- [ ] Traffic Stats
- [ ] Traffic Vault
- [ ] unknown
## Current behavior:
The Go version of GET /deliveryservice_stats limits the metric types to the
following:
```
dsMetricTypes = map[string]interface{}{
"kbps": struct{}{},
"tps_total": struct{}{},
"tps_2xx": struct{}{},
"tps_3xx": struct{}{},
"tps_4xx": struct{}{},
"tps_5xx": struct{}{},
}
```
Therefore making it impossible to fetch `metricType=foo` for example. The
Perl version did not restrict the metric types but rather it simply added
whatever metric type to the influx query.
I would suggest fixing this in 1.x and 2.x (which is already part of TC 4.1)
and potentially redesigning the entire endpoint for 3.x (which is part of TC
5.0). I'll create a separate issue for that.
## Expected / new behavior:
GET /api/deliveryservice_stats does not limit metric types to a predefined
set.
## Minimal reproduction of the problem with instructions:
GET /api/1.4/deliveryservice_stats?metricType=foo will return a 400 bad
request.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
