dneuman64 commented on pull request #4742: URL: https://github.com/apache/trafficcontrol/pull/4742#issuecomment-636862571
I understand the need for this and why Jeremy is fixing it. We should allow some sort of latitude in the API to allow for some customization, but maybe not just strings. What if we changed the code so the requesting user had to pass in a metric that pattern matched whatever we define? So instead of ONLY allowing `kbps` we allow `kbps*` so that if we wanted to create a metric called `kbps_custom` it would still work? I think that would satisfy our need to not have such a strict API while also keeping some safety. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
