rob05c opened a new pull request #4757: URL: https://github.com/apache/trafficcontrol/pull/4757
Adds a __RANGE_DIRECTIVE__ to the Raw Remap processing, to insert the Delivery Service Range Request Handling directives there, instead of before the Raw Remap. Normally, Raw Remap always needs to be at the end of the remap line, but in some cases, specifically when custom remaps are modifying the Range header, it's necessary to put the Range Request directives (@plugin=slice.so, @plugin=cache_raange_requests.so, etc) after the custom Raw Remap text. This makes that possible. Tested manually, verified range directives are placed over __RANGE_DIRECTIVE__ in the Raw Remap, range directives are placed as normally if no directive exists, range plugins aren't double-placed. Includes unit tests verifying same. Fixes #4755 Includes tests. Includes docs. Includes changelog. - [x] This PR fixes #4755 ## Which Traffic Control components are affected by this PR? - Traffic Ops ORT ## What is the best way to verify this PR? Run tests. Create a Delivery Service with a Range Request Handling: Slice, and a Raw Remap of `sometext __RANGE_DIRECTIVE__`, queue updates, verify the `@plugin=slice.so` is after `sometext` in `remap.config` on the cache. Remove `__RANGE_DIRECTIVE__` from the Delivery Service, queue, verify Raw Remap Text is at the end of the line like it should be. ## If this is a bug fix, what versions of Traffic Control are affected? This is somewhat between a bug fix and a feature. It's a feature that fixes a critical issue in a new feature in 4.1, #4455 - master - 4.1 ## The following criteria are ALL met by this PR - [x] This PR includes tests OR I have explained why tests are unnecessary - [x] This PR includes documentation OR I have explained why documentation is unnecessary - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary - [x] This PR includes any and all required license headers - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details) ## Additional Information ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
