shamrickus commented on a change in pull request #4644:
URL: https://github.com/apache/trafficcontrol/pull/4644#discussion_r437608733
##########
File path: lib/go-atscfg/cacheurldotconfig.go
##########
@@ -101,11 +97,10 @@ func MakeCacheURLDotConfig(
// TODO verify prefix and suffix exist, and warn if they don't? Perl
doesn't
dsName :=
tc.DeliveryServiceName(strings.TrimSuffix(strings.TrimPrefix(fileName,
"cacheurl_"), ".config"))
- ds, ok := dses[dsName]
+ _, ok := dses[dsName]
if !ok {
return text // TODO warn? Perl doesn't
}
- text += ds.CacheURL + "\n"
Review comment:
I believe I have properly removed up the chain, might be some I missed
in atstccfg though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
