mitchell852 commented on a change in pull request #4788:
URL: https://github.com/apache/trafficcontrol/pull/4788#discussion_r439480001
##########
File path: traffic_portal/bower.json
##########
@@ -1,23 +1,17 @@
{
"name": "traffic_portal",
"dependencies": {
- "angular": "1.7.8",
- "angular-animate": "1.7.8",
"angular-resource": "1.7.8",
Review comment:
by leaving these other angular ones in bower.json, its still pulling
angular in via `bower install`
```
angular-bootstrap#0.14.3 app/bower_components/angular-bootstrap
└── angular#1.7.8
```
so i would suggest either a) limiting this PR to just removing unused deps
(es5-shim and json3) and moving the migration of all angular* to npm to another
PR or b) moving ALL of the angular* deps to npm in this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
