mitchell852 commented on a change in pull request #4747:
URL: https://github.com/apache/trafficcontrol/pull/4747#discussion_r439510340
##########
File path:
traffic_portal/app/src/common/modules/table/cacheGroupServers/TableCacheGroupServersController.js
##########
@@ -17,11 +17,13 @@
* under the License.
*/
-var TableCacheGroupsServersController = function(cacheGroup, servers,
$controller, $scope, $state, $uibModal, cacheGroupService) {
+var TableCacheGroupsServersController = function(cacheGroup, servers,
$controller, $scope, $state, $uibModal, cacheGroupService, serverUtils) {
// extends the TableServersController to inherit common methods
angular.extend(this, $controller('TableServersController', { servers:
servers, $scope: $scope }));
+ $scope.serverNetInfo = new Map(servers.map(function(s){return [s.id,
serverUtils.toLegacyIPInfo(s.interfaces)];}));
Review comment:
you should be able to just put this in the `TableServersController`
which is the parent controller to all of these controllers rather than
duplicating it across all server controllers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
