rawlinp commented on a change in pull request #4797:
URL: https://github.com/apache/trafficcontrol/pull/4797#discussion_r440930727



##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -51,6 +51,12 @@ import (
 const serverCountQuery = `
 SELECT COUNT(s.id)
 FROM server AS s
+JOIN cachegroup cg ON s.cachegroup = cg.id

Review comment:
       Since this is the exact same `FROM ... JOIN`s as the main `selectQuery` 
below, should we move this into a constant and share them between both queries?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to