ocket8888 commented on a change in pull request #4774:
URL: https://github.com/apache/trafficcontrol/pull/4774#discussion_r441082170
##########
File path: traffic_ops/traffic_ops_golang/monitoring/monitoring.go
##########
@@ -151,27 +176,101 @@ func GetMonitoringJSON(tx *sql.Tx, cdnName string)
(*Monitoring, error) {
}
func getMonitoringServers(tx *sql.Tx, cdn string) ([]Monitor, []Cache,
[]Router, error) {
Review comment:
I can't quite tell exactly what's going on here, but in CDN-in-a-Box I
have this edge server (extraneous fields omitted):
```json
{ "interfaces": [
{
"ipAddresses": [
{
"address": "172.19.0.4/16",
"gateway": "172.19.0.1",
"serviceAddress": true
}
],
"maxBandwidth": null,
"monitor": false,
"mtu": 1500,
"name": "eth0"
}
]}
```
and in the monitoring payload it shows me these interfaces for the same
server:
```json
{ "interfaces": [
{
"ipAddresses": [
{
"address": "172.19.0.5/16",
"gateway": "172.19.0.1",
"serviceAddress": true
}
],
"maxBandwidth": null,
"monitor": false,
"mtu": 1500,
"name": "eth0"
},
{
"ipAddresses": [
{
"address": "172.19.0.10/16",
"gateway": "172.19.0.1",
"serviceAddress": true
}
],
"maxBandwidth": null,
"monitor": false,
"mtu": 1500,
"name": "eth0"
},
{
"ipAddresses": [
{
"address": "172.19.0.4/16",
"gateway": "172.19.0.1",
"serviceAddress": true
}
],
"maxBandwidth": null,
"monitor": false,
"mtu": 1500,
"name": "eth0"
},
{
"ipAddresses": [
{
"address": "172.19.0.11/16",
"gateway": "172.19.0.1",
"serviceAddress": true
}
],
"maxBandwidth": null,
"monitor": false,
"mtu": 1500,
"name": "eth0"
}
]}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
