rawlinp opened a new pull request #4807: URL: https://github.com/apache/trafficcontrol/pull/4807
## What does this PR (Pull Request) do? Add the new `firstHeaderRewrite`, `innerHeaderRewrite`, and `lastHeaderRewrite` fields to delivery services. These fields can only be used when the delivery service is assigned to a topology and are mutually exclusive with `edgeHeaderRewrite` and `midHeaderRewrite`, which can **not** be used if the delivery service is assigned to a topology. **NOTE:** this PR intentionally does *not* create and link "location" parameters for these new header rewrite fields, because this extra information is unnecessary for client-side config generation via `atstccfg` and would just lead to a load of unnecessary complexity. Additionally, I think we should get rid of "location" parameters altogether, so increasing and perpetuating their usage is not ideal. - [x] This PR is not related to any Issue ## Which Traffic Control components are affected by this PR? - Traffic Ops ## What is the best way to verify this PR? Run the unit tests and TO API tests, verify they pass. ## The following criteria are ALL met by this PR - [ ] This PR includes tests OR I have explained why tests are unnecessary - [ ] This PR includes documentation OR I have explained why documentation is unnecessary - [ ] This PR includes an update to CHANGELOG.md OR such an update is not necessary - [x] This PR includes any and all required license headers - [x] This PR ensures that database migration sequence is correct - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
