zrhoffman commented on a change in pull request #4821:
URL: https://github.com/apache/trafficcontrol/pull/4821#discussion_r444609281
##########
File path: infrastructure/cdn-in-a-box/docker-compose.yml
##########
@@ -58,10 +58,10 @@ services:
# defined below
trafficops:
build:
- context: ../..
- dockerfile: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile-go
+ context: .
+ dockerfile: traffic_ops/Dockerfile-go
args:
- TRAFFIC_OPS_RPM:
infrastructure/cdn-in-a-box/traffic_ops/traffic_ops.rpm
+ TRAFFIC_OPS_RPM: traffic_ops/traffic_ops.rpm
Review comment:
These path changes also need to be made to the `trafficops-go-nondebug`
service in `/infrastructure/cdn-in-a-box/optional/docker-compose.debugging.yml`
##########
File path: infrastructure/cdn-in-a-box/traffic_ops/Dockerfile-go
##########
@@ -45,18 +45,18 @@ FROM trafficops-common-deps
# Override TRAFFIC_OPS_RPM arg to use a different one using --build-arg
TRAFFIC_OPS_RPM=... Can be local file or http://...
#
-ARG TRAFFIC_OPS_RPM=infrastructure/cdn-in-a-box/traffic_ops/traffic_ops.rpm
-
-COPY $TRAFFIC_OPS_RPM /
-RUN to_rpm_filename="$(basename $TRAFFIC_OPS_RPM)" && \
- rpm --install --nodeps --verbose --hash "$to_rpm_filename" && \
- rm "$to_rpm_filename"
-
-COPY infrastructure/cdn-in-a-box/enroller/server_template.json \
- infrastructure/cdn-in-a-box/traffic_ops/config.sh \
- infrastructure/cdn-in-a-box/traffic_ops/run-go.sh \
- infrastructure/cdn-in-a-box/traffic_ops/to-access.sh \
- /
+ARG TRAFFIC_OPS_RPM=traffic_ops/traffic_ops.rpm
+
+COPY $TRAFFIC_OPS_RPM /
+RUN to_rpm_filename="$(basename $TRAFFIC_OPS_RPM)" && \
+ rpm --install --nodeps --verbose --hash "$to_rpm_filename" && \
+ rm "$to_rpm_filename"
+
+COPY enroller/server_template.json \
+ traffic_ops/config.sh \
+ traffic_ops/run-go.sh \
+ traffic_ops/to-access.sh \
+ /
Review comment:
These path changes need to be made in
`/infrastructure/cdn-in-a-box/traffic_ops/Dockerfile-go.dockerignore` for any
Docker BuildKit users
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
