mitchell852 commented on a change in pull request #4878:
URL: https://github.com/apache/trafficcontrol/pull/4878#discussion_r455124362
##########
File path: traffic_portal/package.json
##########
@@ -1,13 +1,14 @@
{
"name": "traffic_portal",
"devDependencies": {
+ "browserify": "^16.5.1",
"connect-livereload": "0.6.1",
"connect-modrewrite": "0.10.2",
"connect-timeout": "1.9.0",
"express": "4.17.1",
"grunt": "1.0.4",
"grunt-adam-compass": "0.7.1",
- "grunt-browserify2": "0.1.8",
+ "grunt-browserify": "^5.3.0",
Review comment:
this always worries me. see how everything else is pinned to a version?
i got burned in the past when not pinning to a version.....then again that's a
good way to fall behind on libraries. but i suppose our ci pipieline is better
now and should catch any problems as a result of library upgrades.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
