mitchell852 commented on a change in pull request #4881:
URL: https://github.com/apache/trafficcontrol/pull/4881#discussion_r455880466



##########
File path: traffic_ops/traffic_ops_golang/server/servers.go
##########
@@ -1224,6 +1228,9 @@ func createV3(inf *api.APIInfo, w http.ResponseWriter, r 
*http.Request) {
                return
        }
 
+       str := uuid.New().String()

Review comment:
       sorry, i just did a quick glance at the code. what happens on server 
update (PUT /servers/{id})? can the user change the XMPPID? If so, that seems 
bad and should be prevented if the XMPPID is driving the hashId value used in 
TR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to