rimashah25 commented on a change in pull request #4881:
URL: https://github.com/apache/trafficcontrol/pull/4881#discussion_r458237103
##########
File path: traffic_ops/testing/api/v2/servers_test.go
##########
@@ -130,6 +136,33 @@ func UpdateTestServers(t *testing.T) {
t.Errorf("results do not match actual: %s, expected: %s",
respServer.Rack, updatedServerRack)
}
+ //Check change in hostname with no change to xmppid
+ if originalHostname == respServer.HostName && originalXMPIDD ==
respServer.XMPPID {
+ t.Errorf("HostName didn't change. Expected: #{updatedHostName},
actual: #{originalHostname}")
+ }
+
+ //Check to verify XMPPID never gets updated
+ changeXMPPID := true
+ if changeXMPPID {
Review comment:
Changed.
##########
File path: traffic_ops/testing/api/v3/servers_test.go
##########
@@ -321,6 +332,33 @@ func UpdateTestServers(t *testing.T) {
t.Fatalf("Cannot test server type change update; server '%s'
had nil type ID", hostName)
}
+ //Check change in hostname with no change to xmppid
+ if originalHostname == *respServer.HostName && originalXMPIDD ==
*respServer.XMPPID {
+ t.Errorf("HostName didn't change. Expected: #{updatedHostName},
actual: #{originalHostname}")
+ }
+
+ //Check to verify XMPPID never gets updated
+ changeXMPPID := true
Review comment:
Changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
