zrhoffman commented on a change in pull request #4790:
URL: https://github.com/apache/trafficcontrol/pull/4790#discussion_r465656652
##########
File path: traffic_ops_ort/atstccfg/config/config.go
##########
@@ -297,4 +297,8 @@ type TOData struct {
// SSLKeys must be all the ssl keys for the server's cdn.
SSLKeys []tc.CDNSSLKeys
+
+ // Topologies must be all the topologies for the server's cdn.
+ // May incude topologies of other cdns.
+ Topologies []tc.Topology
Review comment:
Is there any advantage to having topologies not assigned to any DS? If
not, including a *topologies by DS name* map in `TOData` instead of a topology
array might make more sense, since there are several places where we need to
get a topology, given a certain DS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
